sql - 无法将用户定义的记录插入表中

Question

场景

我创建了一个存储过程，其中将用户定义的表作为参数，然后首先检查 Role_ID 和 Form_ID 是否存在然后我将更新我现有的表。否则我将插入到现有表中。

问题

在我的存储过程中编写插入查询后，我在更改存储过程时遇到以下错误。

Msg 137, Level 16, State 1, Procedure SP_SETUP_ROLES_RIGHTS_SAVE_AND_UPDATE, Line 17 Must declare the scalar variable "@Temp". Msg 137, Level 16, State 1, Procedure SP_SETUP_ROLES_RIGHTS_SAVE_AND_UPDATE, Line 17 Must declare the scalar variable "@Temp".

下面是我的 SP 代码:

CREATE TYPE _ROLERIGHTSSCHEMA as Table (
    _Role_ID int,
    _Form_ID int,
    _Form_Name varchar(100),
    _Can_View bit,
    _Can_Edit bit,
    _Can_Prepare_By bit,
    _Can_Change_Status_By bit,
    _Prepared_By_ID int,
    _Prepared_Date datetime
)

ALTER PROCEDURE SP_SETUP_ROLES_RIGHTS_SAVE_AND_UPDATE
(@Temp _ROLERIGHTSSCHEMA ReadOnly)
AS
BEGIN
    IF EXISTS(SELECT * FROM ROLE_RIGHTS WHERE Role_ID = @Temp.Role_ID AND Form_ID = @Temp.Form_ID)
    BEGIN
        Update Role_Rights
        set Can_View = t._Can_View,
            Can_Edit = t._Can_Edit,
            Can_Prepare_By = t._Can_Prepare_By,
            Can_Change_Status_By = _Can_Change_Status_By,
            Modified_By_ID = 0,
            Modified_Date = GETDATE()
            From @Temp t
            WHERE Role_Rights.Role_ID = t._Role_ID and Role_Rights.Form_ID = t._Form_ID
        END
    ELSE
    BEGIN
        INSERT INTO Role_Rights (
            Role_ID,
            Form_ID,
            Can_View,
            Can_Edit,
            Can_Prepare_By,
            Can_Change_Status_By,
            Prepared_By_ID,
            Prepared_Date
        ) SELECT _Role_ID, _Form_ID, _Can_View, _Can_Edit, _Can_Prepare_By, _Can_Change_Status_By, 0, GETDATE() FROM @Temp
    END
END

Answer 1

要一次更新/插入多条记录，请使用 MERGE :

ALTER PROCEDURE SP_SETUP_ROLES_RIGHTS_SAVE_AND_UPDATE
(@Temp _ROLERIGHTSSCHEMA ReadOnly)
AS
BEGIN
    MERGE Role_Rights rr
    USING @Temp t
      ON rr.Role_ID = t._Role_ID 
         and rr.Form_ID = t._Form_ID
    WHEN MATCHED THEN
       Update set Can_View = t._Can_View,
                    Can_Edit = t._Can_Edit,
                    Can_Prepare_By = t._Can_Prepare_By,
                    Can_Change_Status_By = _Can_Change_Status_By,
                    Modified_By_ID = 0,
                    Modified_Date = GETDATE()
    WHEN NOT MATCHED BY TARGET THEN
       INSERT ( Role_ID,
            Form_ID,
            Can_View,
            Can_Edit,
            Can_Prepare_By,
            Can_Change_Status_By,
            Prepared_By_ID,
            Prepared_Date)
       VALUES (_Role_ID, _Form_ID, _Can_View, _Can_Edit,
               _Can_Prepare_By, _Can_Change_Status_By, 0, GETDATE() );
END;

编辑:

MERGE over IF EXISTS/UPDATE/INSERT set based:

Single insert   -- no difference
Single update   -- no difference
Multiple insert -- no difference
Multiple update -- no difference
Multiple insert/update:  MERGE     -- will handle it correctly 
                         IF EXISTS -- you will lose records to insert

---

不带 IF 部分的更新/插入:

Update Role_Rights
        set Can_View = t._Can_View,
            Can_Edit = t._Can_Edit,
            Can_Prepare_By = t._Can_Prepare_By,
            Can_Change_Status_By = _Can_Change_Status_By,
            Modified_By_ID = 0,
            Modified_Date = GETDATE()
            From @Temp t
WHERE Role_Rights.Role_ID = t._Role_ID and Role_Rights.Form_ID = t._Form_ID;

INSERT INTO Role_Rights (
        Role_ID,
        Form_ID,
        Can_View,
        Can_Edit,
        Can_Prepare_By,
        Can_Change_Status_By,
        Prepared_By_ID,
        Prepared_Date
    ) 
 SELECT _Role_ID, _Form_ID, _Can_View, _Can_Edit,
        _Can_Prepare_By, _Can_Change_Status_By, 0, GETDATE() 
 FROM @Temp t
 WHERE NOT EXISTS (SELECT 1
                   FROM Role_Rights rr
                   WHERE rr.Role_ID = t._Role_ID 
                     and rr.Form_ID = t._Form_ID);