java - 用谓词组合Java中两个相似的方法

Question

就主体而言，我有两个类似的方法，但参数数量不同，并且内部有一个额外的条件。我知道有一种方法可以使用谓词将它们合并到一个方法中，但我不完全确定如何实现它。解决这个问题的最佳方法是什么？

public boolean checkIfAllCodesAreUnique(List<String> bsnCodes)
{
    List<Businesscode> codes = ConverterUtil.iterableToList(businessCodeService.findAll());
    if(codes != null && !codes.isEmpty() && bsnCodes != null && !bsnCodes.isEmpty())
        for (String code : bsnCodes)
            if (codes.stream().anyMatch(obj -> code.equals(obj.getCode())))
                return false;
    return true;
}

public boolean checkIfAllCodesAreUnique(List<String> bsnCodes, int idRole)
{
    List<Businesscode> codes = ConverterUtil.iterableToList(businessCodeService.findAll());
    if(codes != null && !codes.isEmpty() && bsnCodes != null && !bsnCodes.isEmpty())
        for (String code : bsnCodes)
            if (codes.stream().anyMatch(obj -> code.equals(obj.getCode()) && obj.getId() != idRole))
                return false;
    return true;
}

Answer 1

public boolean checkIfAllCodesAreUnique(List<String> bsnCodes) {
    return isAllCodesAreUnique(bsnCodes, businessCode -> true);
}

public boolean checkIfAllCodesAreUnique(List<String> bsnCodes, int idRole) {
    return isAllCodesAreUnique(bsnCodes, businessCode -> businessCode.getId() != idRole);
}

private boolean isAllCodesAreUnique(List<String> bsnCodes, Predicate<Businesscode> checkRole) {
    List<Businesscode> businessCodes = Optional.ofNullable(ConverterUtil
            .iterableToList(businessCodeService.findAll())).orElse(List.of());

    for (String bsnCode : Optional.ofNullable(bsnCodes).orElse(List.of())) {
        if (businessCodes.stream()
                         .filter(businessCode -> bsnCode.equals(businessCode.getCode()))
                         .anyMatch(checkRole))
            return false;
    }

    return true;
}