java - 从列表中创建玩家团队

Question

嘿，我正在尝试创建一种随机方法来从链接列表中选择一个 4 人团队，我想知道这段代码是否有效。

这是一个示例代码

 public static void enterGame(Client c) {
    int n = teamSize;
    boolean startNewGame = false;
    if(waitingPlayers.size() <= 3) {
        return; // not enough players
    }
    startNewGame = true;
    if(startNewGame) {
        System.out.println("Starting new game");
        for(int i=0; i<n; i++) {
            Collections.shuffle(waitingPlayers);
            System.out.println("Picking random player");
            waitingPlayers.remove(c);
            System.out.println("removing from random player list");
            players.add(c);
            System.out.println("adding player to ingame list");
        }
    }
}

Answer 1

我会使用Collections.shuffle()和一个子列表。为了知道你的代码是否有效，你为什么不测试它(单元测试或只是一些尝试)？

另外，这部分:

boolean startNewGame = false;
if(waitingPlayers.size() > 3) {
        startNewGame = true;
} else {
        startNewGame = false;
        return;
}
if(startNewGame) {

太复杂了，我将其替换为:

if(waitingPlayers.size() <= 3) {
    return; // not enough players
}

完整代码:

public static void enterGame(final Client c) {      
    if(waitingPlayers.size() <= 3) {
        return; // not enough players
    }

    System.out.println("Starting new game");
    Collections.shuffle(waitingPlayers);
    System.out.println("Picking random players");
    // ? to be replaced by the real type of objects inside waitingPlayers
    final List<?> picked = waitingPlayers.subList(0, 3); 
    players.addAll(picked);
    waitingPlayers.removeAll(picked);
}