python - 将列表解析为另一个函数参数 - Python

Question

我有一个 .log 文件，我想检查其中是否有错误/警告:

    2018-03-05 10:55:54,636 INFO The file: C:/test/Abu/TRS.ABU.GEN.003_1/input\ASWC_M740.aswc.arxml is well-formed
    2018-03-05 10:55:55,193 INFO The file: C:/test/Abu/TRS.ABU.GEN.003_1/input\ASWC_M740.aswc.arxml is valid with the AUTOSAR4.2.2-STRICT schema
    2018-03-05 10:55:55,227 INFO The file: C:/test/Abu/TRS.ABU.GEN.003_1/input\ASWC_M741.aswc.arxml is well-formed
    2018-03-05 10:55:55,795 INFO The file: C:/test/Abu/TRS.ABU.GEN.003_1/input\ASWC_M741.aswc.arxml is valid with the AUTOSAR4.2.2-STRICT schema
    2018-03-05 10:55:55,831 INFO The file: C:/test/Abu/TRS.ABU.GEN.003_1/input\ASWC_M742.aswc.arxml is well-formed
    2018-03-05 10:55:56,403 INFO The file: C:/test/Abu/TRS.ABU.GEN.003_1/input\ASWC_M742.aswc.arxml is valid with the AUTOSAR4.2.2-STRICT schema
    2018-03-05 10:55:56,438 WARNING ASWC_M740_MSI is without connector
2018-03-05 10:55:56,438 ERROR ASWC_M741_MSI is without connector
    2018-03-05 10:55:56,438 WARNING PRP_CS_VehicleSPeed is without connector

到目前为止，我已经成功编写了下一个函数，但没有成功:

def checkLog(path, level, message):
    """
    path = used for defining the file to be checked
    level = criticity level :INFO, WARNING, ERROR
    message = string to be matched
    """
    datafile = open(path)
    line_file = datafile.readline()
    while line_file != "":
        for text in message:
            if level + " " + text in line_file:
                return True
            line_file = datafile.readline()
    return False

checkLog("C:\\test\Abu\TRS.ABU.GEN.003_1\output\\result.log", "WARNING", ["PRP_CS_VehicleSPeed", "ASWC_M740_MSI", "ASWC_M741_MSI"])

我哪里错了？

Answer 1

第二个 readline() 位于 for 循环内，它迭代可能要匹配的消息，因此在检查所有消息之前代码会移至下一行。

尝试将其移至外部范围:

def checkLog(path, level, message):
    datafile = open(path)
    line_file = datafile.readline()
    while line_file != "":
        for text in message:
            if level + " " + text in line_file:
                return True
        line_file = datafile.readline()
    return False

你的代码可以更好地写成这样:

def checkLog(path, level, message):
    with open(path) as datafile:
        for line in datafile:
            for text in message:
                if (level + " " + text) in line:
                    return True
    return False

这避免了调用readline()，而是迭代文件对象，从而简化了代码。它还使用上下文管理器(with 语句)打开文件，这将确保文件正确关闭。