JavaFX 访问 Controller 给出空指针异常

标签 java javafx javafx-2

我想要实现的是从 main 方法获取 Controller 实例,这样我就可以从另一个类调用 Controller 的方法并更新 fxml。不管怎样,这是我的代码:

主类:

public class Main extends Application {

Controller controller;
@Override
public void start(Stage primaryStage) throws Exception{

    FXMLLoader fxmlLoader = new FXMLLoader();

    Parent root = fxmlLoader.load(getClass().getResource("sample.fxml"));
    controller = fxmlLoader.getController();

    primaryStage.setTitle("uPick Smart Service");
    primaryStage.setScene(new Scene(root, 1600, 600));

    primaryStage.show();

    ConnectionHandling connectionHandling = new ConnectionHandling();
    Thread X = new Thread (connectionHandling);
    X.start();

}

public static void main(String args[]){
    launch(args);

}

public Controller getController(){
    return controller;
}


}

我的 Controller 类:

public class Controller {

public HBox billbox;

public int childnr;


public void createBill() {
    System.out.println("Creating");
    TableView<Item> bill = new TableView<>();

    DropShadow dropShadow = new DropShadow();
    dropShadow.setRadius(5.0);
    dropShadow.setOffsetX(3.0);
    dropShadow.setOffsetY(3.0);
    dropShadow.setColor(Color.color(0.4, 0.5, 0.5));

    VBox fullbill = new VBox();
    fullbill.setPadding(new Insets(1, 1, 1, 1));
    fullbill.getStyleClass().add("fullbill");

    TableColumn<Item, String> nameColumn = new TableColumn<>("Emri");
    nameColumn.setMinWidth(200);
    nameColumn.setCellValueFactory(new PropertyValueFactory<>("name"));

    TableColumn<Item, String> quantsColumn = new TableColumn<>("Sasia");
    quantsColumn.setMinWidth(50);
    quantsColumn.setCellValueFactory(new PropertyValueFactory<>("quants"));

    double tablewidth = nameColumn.getWidth() + quantsColumn.getWidth();

    Label tablenrlabel = new Label("Table 5");
    tablenrlabel.getStyleClass().add("tablenr-label");
    tablenrlabel.setMinWidth(tablewidth);

    Button closebutton = new Button("Mbyll");
    closebutton.setMinWidth(tablewidth);
    closebutton.getStyleClass().add("red-tint");

    bill.setItems(getItem());
    bill.setMinWidth(256);
    bill.setColumnResizePolicy(TableView.CONSTRAINED_RESIZE_POLICY);
    bill.getColumns().addAll(nameColumn, quantsColumn);

    fullbill.setEffect(dropShadow);
    fullbill.getChildren().addAll(tablenrlabel, bill, closebutton);

    billbox.getChildren().addAll(fullbill);

    childnr += 1;

    //Loops over every button in every vbox and gives it a seperate listener (the index of the button is hardcoded so it can cause problems if you add more items)
    for (int i = 0; i < childnr; i++) {
        VBox box = (VBox) billbox.getChildren().get(i);
        Button btn = (Button) box.getChildren().get(2); //if sudden issues change this
        btn.setId(Integer.valueOf(i).toString());
        btn.setOnAction(new EventHandler<ActionEvent>() {
            @Override
            public void handle(ActionEvent event) {
                int index = billbox.getChildren().indexOf(btn.getParent());
                billbox.getChildren().remove(index);
                childnr -= 1;
                System.out.println(btn.getId());
            }
        });
    }
    System.out.println("done");
}

}

类试图调用 Controller 方法:

public class TakeOrder implements Runnable {
Socket SOCK;
Controller controller;

//OrderIndexes: "Order","Waiter","Payment"

private int NonConnectedDatas = 2;

public TakeOrder(Socket X){
    this.SOCK = X;
}

public void CheckConnection() throws IOException{
    System.out.println("Checking connection");
    if(!SOCK.isConnected()){
        System.out.println("Dissconectiong");
        for(int i = 0; i < ConnectionHandling.ConnectionArray.size(); i++){
            if(ConnectionHandling.ConnectionArray.get(i) == SOCK){
                ConnectionHandling.ConnectionArray.remove(i);
            }
        }
    }
}

public void run(){
    try{
        try{
            CheckConnection();


            ObjectInputStream ob = new ObjectInputStream(SOCK.getInputStream());

            String[] structuredArray = (String[])ob.readObject();

            String tablenr = structuredArray[0];
            String index = structuredArray[1];

            ArrayList<String> names = new ArrayList<>();
            ArrayList<String> quants = new ArrayList<>();

            int a = 0;
            int b = 0;
            switch (index) {
                case "Order":
                    for (int i = NonConnectedDatas; i < structuredArray.length; i++) {
                        if (i % 2 == 0) {
                            names.add(a, structuredArray[i]);
                            System.out.println(names.get(a));
                            a++;
                        } else {
                            quants.add(b, structuredArray[i]);
                            System.out.println(quants.get(b));
                            b++;
                        }
                    }
                    break;
            }

            Platform.runLater(new Runnable() {
                @Override
                public void run() {

                }
            });
        }finally{
            SOCK.close();
        }
    }catch(Exception X){
        System.out.print(X);
    }
}



}

这是我的错误信息:

Exception in thread "JavaFX Application Thread" java.lang.NullPointerException
at sample.TakeOrder$1.run(TakeOrder.java:80)
at com.sun.javafx.application.PlatformImpl.lambda$null$173(PlatformImpl.java:295)
at java.security.AccessController.doPrivileged(Native Method)
at com.sun.javafx.application.PlatformImpl.lambda$runLater$174(PlatformImpl.java:294)
at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
at com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
at com.sun.glass.ui.win.WinApplication.lambda$null$148(WinApplication.java:191)
at java.lang.Thread.run(Thread.java:745)

连接处理类:

public class ConnectionHandling implements Runnable{

public static ArrayList<Socket> ConnectionArray = new ArrayList<Socket>();


public void run(){
    System.out.println("Starting");
    try{
        final int PORT = 60123;
        ServerSocket SERVER = new ServerSocket(PORT);
        System.out.println("Waiting for clients");
        while(true){
            Socket SOCK = SERVER.accept();
            ConnectionArray.add(SOCK);

            TakeOrder ORDER = new TakeOrder(SOCK);
            Thread X = new Thread(ORDER);
            X.setDaemon(true);
            X.start();
        }
    }catch(Exception x){
        System.out.print(x);
    }

}

最佳答案

首先,您使用的是 static FXMLLoader.load(URL)方法。因为它是 static,所以您创建的 FXMLLoader 实例的 Controller 属性不会通过调用此 load 方法进行初始化。因此 Main 中的 controller 将为 null

相反,设置位置并使用实例方法load() :

@Override
public void start(Stage primaryStage) throws Exception{

    FXMLLoader fxmlLoader = new FXMLLoader();
    fxmlLoader.setLocation(getClass().getResource("sample.fxml"));

    Parent root = fxmlLoader.load();
    controller = fxmlLoader.getController();

    primaryStage.setTitle("uPick Smart Service");
    primaryStage.setScene(new Scene(root, 1600, 600));

    primaryStage.show();



}

不过,这并不能完全解决您的问题。当您启动该应用程序时,JavaFX 将创建一个 Main 实例并对该实例调用 start()。通过上述更改,该实例controller 字段将被正确初始化。

但是,在 TakeOrder.run() 中,您创建了另一个 Main 实例:

Main main = new Main();

该实例的 controller 字段不会被初始化(即使您确实初始化了它,它也与您想要的实例不同)。因此,您确实需要安排 TakeOrder 访问在启动方法中创建的 Controller 实例

这是对您的代码进行最直接的修复以使其正常工作:

public class ConnectionHandling implements Runnable{

    private final Controller controller ;

    public ConnectionHandling(Controller controller) {
        this.controller = controller ;
    }

    // ...

    public void run(){

        // existing code ...

        TakeOrder ORDER = new TakeOrder(SOCK, connection);

        // ...
    }
}

public class TakeOrder implements Runnable {

    Socket SOCK;
    Controller controller;

    //OrderIndexes: "Order","Waiter","Payment"

    private int NonConnectedDatas = 2;

    public TakeOrder(Socket X, Controller controller){
        this.SOCK = X;
        this.controller = controller ;
    }

    // ...

    public void run() {

        // ...

        Platform.runLater(controller::createBill);

        // ...
    }

}

最后

public class Main extends Application {

    @Override
    public void start(Stage primaryStage) throws Exception{

        FXMLLoader fxmlLoader = new FXMLLoader();

        Parent root = fxmlLoader.load(getClass().getResource("sample.fxml"));
        Controller controller = fxmlLoader.getController();

        primaryStage.setTitle("uPick Smart Service");
        primaryStage.setScene(new Scene(root, 1600, 600));

        primaryStage.show();

        ConnectionHandling connectionHandling = new ConnectionHandling(controller);
        Thread X = new Thread (connectionHandling);
        X.start();

    }

    public static void main(String args[]){
        launch(args);

    }

    public Controller getController(){
        return controller;
    }


}

一般来说,对于这样的应用程序,您可能需要考虑使用 MVC 或 MVP 方法(即您需要一个 model 类,它将包含服务,例如您的 ConnectionHandler).

您可能还对 this article 感兴趣关于在 JavaFX 中集成服务。

关于JavaFX 访问 Controller 给出空指针异常,我们在Stack Overflow上找到一个类似的问题: https://stackoverflow.com/questions/38932921/

相关文章:

java - 如何在 Java 中仅将字符串数字保留在字符串数组中?

java - 找不到 NetBeans 10 JUnit Jar

仅使用 JavaScript (Nashorn) 进行 JavaFX 开发

java - javafx 主要方法 launch(args) 是如何工作的?

java - 确定 JavaFX WebView 何时完成渲染

Java 父类(super class) toString() 和构造函数调用

java - 需要从多个 JList 中删除,而不仅仅是一个

java - 如何创建具有跨运行时持续存在的信息的变量

java - 在网页上运行java(FX)制作的应用程序

java - 我可以在不分发源代码的情况下将 JavaFX 2.x 用于我的应用程序吗?