c++ - 我的 While 循环不会在条件处停止

标签 c++ while-loop

我正在运行一个纸牌游戏,两个玩家轮流挑选纸牌,玩家向前走那么多格子。在这种情况下,一旦任一玩家达到 25 或更大的数字,他们就会点击 Home,游戏应该停止。

//This is the function that plays the entire game
    void play(int size, int &player1, int &player2, int cardPile[], int board[]){
        displayRules();

        while(player1 < 25 || player2 < 25){
        cout << "\nPlayer 1's turn!" << endl;
        takeTurn(size, player1, cardPile, board, player2);
        showState(player1, player2);
        cout << "\nPlayer 2's turn!" << endl;
        takeTurn(size, player2, cardPile, board, player1);
        showState(player1, player2);
        }

    }

我的 while 循环在两个玩家都达到 25 后继续循环,即使我已将条件设置为在玩家 1 的值小于 25 或玩家 2 的值小于 25 时循环。

#include <iostream>
#include <cstdlib>
#include <cmath>

using namespace std;

void play(int size, int &player1, int &player2, int cardPile[], int board[]);
void displayRules();
int takeTurn(int size, int &player, int cardPile[], int board[], int &opposingPlayer);
int shuffleDeck(int size, int cardPile[]);
int switchPlaces(int &player, int &opposingPlayer);
int obstacles(int &player, int board[]);
void showState(int &player1, int &player2);
void youWin(int &player1, int &player2);


int main()
{
    const int size = 10;
    int board[] = {0, 1, 0, 0, 1, 0, 0, 0, 2, 0, 0, 0, 3, 0, 0, 0, 2, 0, 0, 0, 1, 0, 0, 0, 0, 0};
    int cardPile[size] = {1, 1, 2, 2, 3, 3, 4, 4, 0, 5};
    int player1 = 0;
    int player2 = 0;

    play(size, player1, player2, cardPile, board);
    return 0;
}

//This is the function that plays the entire game
void play(int size, int &player1, int &player2, int cardPile[], int board[]){
    displayRules();

    while(player1 < 25 || player2 < 25){
    cout << "\nPlayer 1's turn!" << endl;
    takeTurn(size, player1, cardPile, board, player2);
    showState(player1, player2);
    cout << "\nPlayer 2's turn!" << endl;
    takeTurn(size, player2, cardPile, board, player1);
    showState(player1, player2);
    }

}

//This function does a single turn for each player
int takeTurn(int size, int &player, int cardPile[], int board[],int &opposingPlayer){
    shuffleDeck(size, cardPile);
    int i = 0;
    if(cardPile[i] == 0)
        cout << "You drew a Lose a turn card! You lose a turn!" << endl;

    else if(cardPile[i] == 5)
        cout << "You drew a Switch Places card! You must switch places with the other player!" << endl,
        switchPlaces(player, opposingPlayer);

    else
    cout << "You drew a " << cardPile[i] << "!";
        switch(cardPile[i]){
        case 1:
            cout << " Move forward " << cardPile[i] << " space on the board!" << endl;
            player += cardPile[i];
            obstacles(player, board);
            break;
        case 2:
            cout << " Move forward " << cardPile[i] << " spaces on the board!" << endl;
            player += cardPile[i];
            obstacles(player, board);
            break;
        case 3:
            cout << " Move forward " << cardPile[i] << " spaces on the board!" << endl;
            player += cardPile[i];
            obstacles(player, board);
            break;
        case 4:
            cout << " Move forward " << cardPile[i] << " spaces on the board!" << endl;
            player += cardPile[i];
            obstacles(player, board);
            break;

        }

}

//This function shuffles the deck of cards
int shuffleDeck(int size, int cardPile[]){

    srand(time(0));
    for(int i = 0; i < size; i++){
            int index = rand() % size;
            int temp = cardPile[i];
            cardPile[i] = cardPile[index];
            cardPile[index] = temp;
    }

}


//This is the function that tells a player when they have ran into an
//obstacle and moves them back the appropriate number of spaces
int obstacles(int &player, int board[]){
    if(player == 1)
        player -= 1,
        cout << "You ran into an obstacle! Move back 1 space!" << endl;
    else if(player == 4)
        player -= 1,
        cout << "You ran into an obstacle! Move back 1 space!" << endl;
    else if(player == 8)
        player -= 2,
        cout << "You ran into an obstacle! Move back 2 spaces!" << endl;
    else if(player == 12)
        player -= 3,
        cout << "You ran into an obstacle! Move back 3 spaces!" << endl;
    else if(player == 16)
        player -= 2,
        cout << "You ran into an obstacle! Move back 2 spaces!" << endl;
    else if(player == 20)
        player -= 1,
        cout << "You ran into an obstacle! Move back 1 space!" << endl;
}

while 循环条件哪里出错了?

编辑:这是我运行的其中一项测试的一些输出。

Welcome to GoHome! The main objective of this game is to reach Home first.
The basic rules of the game are as follows:

-To begin the player with the shortest name goes first.
-Each player picks a card that has a number on it and the player must moves forward that many number of spaces.
-If a card says 'Lose A Turn', the player does nothing and theturn moves to the next player.
-If a card says 'Switch Places', that player is allowed to switch places with any player on the board.
-If a player lands on an obstacle, that player must move back that many number of spaces.
-If a player lands another obstacle while moving backwards, then it does not have to move backwards again.

0
0

Player 1's turn!
You drew a 3! Move forward 3 spaces on the board!

Player 1 is on spot 3 of the board.
Player 2 is at Start!


Player 2's turn!
You drew a 4! Move forward 4 spaces on the board!
You ran into an obstacle! Move back 1 space!

Player 1 is on spot 3 of the board.
Player 2 is on spot 3 of the board.

3
3

Player 1's turn!
You drew a 1! Move forward 1 space on the board!
You ran into an obstacle! Move back 1 space!

Player 1 is on spot 3 of the board.
Player 2 is on spot 3 of the board.


Player 2's turn!
You drew a 3! Move forward 3 spaces on the board!

Player 1 is on spot 3 of the board.
Player 2 is on spot 6 of the board.

3
6

Player 1's turn!
You drew a 4! Move forward 4 spaces on the board!

Player 1 is on spot 7 of the board.
Player 2 is on spot 6 of the board.


Player 2's turn!
You drew a 1! Move forward 1 space on the board!

Player 1 is on spot 7 of the board.
Player 2 is on spot 7 of the board.

7
7

Player 1's turn!
You drew a 3! Move forward 3 spaces on the board!

Player 1 is on spot 10 of the board.
Player 2 is on spot 7 of the board.


Player 2's turn!
You drew a 4! Move forward 4 spaces on the board!

Player 1 is on spot 10 of the board.
Player 2 is on spot 11 of the board.

10
11

Player 1's turn!
You drew a 1! Move forward 1 space on the board!

Player 1 is on spot 11 of the board.
Player 2 is on spot 11 of the board.


Player 2's turn!
You drew a 3! Move forward 3 spaces on the board!

Player 1 is on spot 11 of the board.
Player 2 is on spot 14 of the board.

11
14

Player 1's turn!
You drew a 4! Move forward 4 spaces on the board!

Player 1 is on spot 15 of the board.
Player 2 is on spot 14 of the board.


Player 2's turn!
You drew a 1! Move forward 1 space on the board!

Player 1 is on spot 15 of the board.
Player 2 is on spot 15 of the board.

15
15

Player 1's turn!
You drew a 3! Move forward 3 spaces on the board!

Player 1 is on spot 18 of the board.
Player 2 is on spot 15 of the board.


Player 2's turn!
You drew a 4! Move forward 4 spaces on the board!

Player 1 is on spot 18 of the board.
Player 2 is on spot 19 of the board.

18
19

Player 1's turn!
You drew a 1! Move forward 1 space on the board!

Player 1 is on spot 19 of the board.
Player 2 is on spot 19 of the board.


Player 2's turn!
You drew a 3! Move forward 3 spaces on the board!

Player 1 is on spot 19 of the board.
Player 2 is on spot 22 of the board.

19
22

Player 1's turn!
You drew a 4! Move forward 4 spaces on the board!

Player 1 is on spot 23 of the board.
Player 2 is on spot 22 of the board.


Player 2's turn!
You drew a 1! Move forward 1 space on the board!

Player 1 is on spot 23 of the board.
Player 2 is on spot 23 of the board.

23
23

Player 1's turn!
You drew a 3! Move forward 3 spaces on the board!

Player 1 is on spot 26 of the board.
Player 2 is on spot 23 of the board.


Player 2's turn!
You drew a 4! Move forward 4 spaces on the board!

Player 1 is on spot 26 of the board.
Player 2 is on spot 27 of the board.

最佳答案

好吧,您的条件是“当玩家 1 小于 25 或玩家 2 小于 25 时,执行循环中的操作”。但这绝对不是你想要的。简单地改变:

while(player1 < 25 || player2 < 25){

while(player1 < 25 && player2 < 25){

我认为会完成工作。

这与 De Morgan's laws 有关, 从逻辑上。

此外,请记住,要让程序在任一玩家达到 25 时终止,您必须在每一 回合之后询问,即在每次 takeTurn 调用之后。

关于c++ - 我的 While 循环不会在条件处停止,我们在Stack Overflow上找到一个类似的问题: https://stackoverflow.com/questions/46459643/

相关文章:

c++ - 在 VS2015 中键入 SFINAE 编译,但生成错误

python - 使用按键重新启动 While 循环

C解密程序

python - 在触发器上重新启动的计时器 Python - 如何重新启动?

javascript - while 循环中的 IF 语句不起作用,我哪里出错了?

c++ - Win32 API ListView 创建 (C++)

c++ - 当显式模板实例化定义先于显式声明时,GCC 和 clang 不同意

Powershell - While 语句

c++ - 稍后在 `: , ` 中使用在构造函数的 `: , ` 部分初始化的成员是否安全?

c++ - 如何在现代opengl中绘制圆柱体