位图克隆上的 C# WinForms 内存不足异常

标签 c# winforms bitmap system.drawing

我编写了一个小型“水印”程序来为图像添加自定义水印。有两个水印,一个是白色的,一个是黑色的。水印始终位于图像的左下角。我克隆图像的那个区域,以确定应该根据那个点放置哪个水印(黑色水印在浅色区域,白色水印在深色区域)。

当我在我的机器上使用应用程序(调试或正常)时 - 没问题。所有图像都经过处理,并在正确位置添加了水印。

但是,在客户端机器上,程序在所有图像上中断,在克隆部分抛出 OutOfMemory 异常。

我知道,通常情况下,当我指定一个超出范围的区域时也会抛出 OutOfMemory 异常,但由于该函数在我的机器上运行得非常好,我无法想象会出现这种情况。除此之外,该程序不会在几次尝试后中断,它会在所有克隆尝试后中断。

是否有文本(DrawString 方法)无关紧要。它在克隆上中断。

正在处理的图像很大,但不是“巨大”(最多 6016 x 4000 像素),但即使是较小的图像(3264 x 2448 像素),客户端也会崩溃。

变量:

bmOriginal : 原始位图

processImage : 原始图像 (pictureBox) - bmOriginal 是这个的位图副本

watermarkText : 水印下方额外信息的文本框

blackwhite : 包含水印图像的图片框

watermarkCombo : 用于选择自动、白色或黑色的组合框(自动失败)

代码:

using (Graphics gWatermark = Graphics.FromImage(bmOriginal))
{
    gWatermark.InterpolationMode = System.Drawing.Drawing2D.InterpolationMode.HighQualityBicubic;
    System.Drawing.SolidBrush drawBrush = new System.Drawing.SolidBrush(System.Drawing.Color.Black);

    // position watermark - watermark should be 10% of the image height
    int watermarkHeight = (int)(processImage.Image.Height * 0.1);
    int watermarkPadding = (int)(watermarkHeight * 0.1); // not completely true, but asume watermark is square
    Rectangle watermarkArea = new Rectangle(watermarkPadding, processImage.Image.Height - (watermarkPadding + (watermarkText.Text.Length == 0 ? 0 : watermarkPadding) + watermarkHeight), watermarkHeight, watermarkHeight);

    // determine color watermark
    bmWatermark = (Bitmap)black.Image;
    if (watermarkCombo.SelectedIndex == 0)
    {
        using (Bitmap watermarkClone = bmOriginal.Clone(watermarkArea, bmOriginal.PixelFormat))
        {
            var pixels = Pixels(watermarkClone);
            if (pixels.Average((Func<Color, decimal>)Intensity) < 110) // human eye adoption; normal threshold should be 128
            {
                bmWatermark = (Bitmap)white.Image;
                drawBrush = new System.Drawing.SolidBrush(System.Drawing.Color.White);
            }
        }
    }
    else if (watermarkCombo.SelectedIndex == 1)
    {
        bmWatermark = (Bitmap)white.Image;
        drawBrush = new System.Drawing.SolidBrush(System.Drawing.Color.White);
    }

    // draw the watermark
    gWatermark.DrawImage(bmWatermark, watermarkArea.X, watermarkArea.Y, watermarkArea.Width, watermarkArea.Height);

    // draw the text (if needed)
    if (watermarkText.Text.Length > 0)
    {
        System.Drawing.Font drawFont = new System.Drawing.Font("Tahoma", (float)watermarkPadding);
        gWatermark.DrawString(watermarkText.Text, drawFont, drawBrush, watermarkPadding, bmOriginal.Height - (watermarkPadding * 2));
    }
}
bmOriginal.Save(System.IO.Path.Combine(diWatermarked.FullName, fileName), System.Drawing.Imaging.ImageFormat.Jpeg);

错误行:使用 (Bitmap watermarkClone = bmOriginal.Clone(watermarkArea, bmOriginal.PixelFormat))

现在是个大问题:我如何摆脱 OutOfMemory 异常……有人有想法吗?

编辑 当我选择不自动确定水印的颜色而只添加一个水印(假设是白色的)时,程序运行正常。我在错误日志中看到了堆栈跟踪(在函数捕获时我输出异常和 - 如果有的话 - 内部异常)。

我知道很多使用 Clone 函数的 OOM 异常发生在指定区域越界时;但这里不是这种情况。

当我在 Debug模式下使用应用程序时查看我的内存时,我从 5.36 Gb 程序开始,并且在运行执行时标准化为 5.39 Gb(最大峰值为 5.42 Gb)提到过,它并没有疯狂地消耗内存。

我使用的代码确定平均“颜色”(它来自 StackOverflow 上的某个人 - 我只是从其他答案中复制了它,但找不到链接);

// functions used to determine watermark color
private static decimal ComponentAverage(decimal a, decimal b)
{
    return Math.Min(a, b) + Math.Abs(a - b) / 2M;
}
private static decimal Intensity(Color color)
{
    decimal result = color.A;
    result = ComponentAverage(result, color.R);
    result = ComponentAverage(result, color.G);
    result = ComponentAverage(result, color.B);
    return result;
}
private static IEnumerable<Color> Pixels(Bitmap bitmap)
{
    for (int x = 0; x < bitmap.Width; x++)
        for (int y = 0; y < bitmap.Height; y++)
            yield return bitmap.GetPixel(x, y);
}

SOURCE 这里有一个测试项目:http://hotpepper.nu/oomtestapp.zip

最佳答案

Leon,我已将您上传的代码更改为不锁定任何资源。 我注意到,如果我让您的应用程序保持打开状态,我将无法删除输出文件夹,因为某些文件正在使用中。这通常意味着您没有释放所有文件句柄,基本上它总是最后一个文件。

我无法在我的计算机上重现更改前后的内存不足问题,似乎是非常大的文件的问题?

无论如何,我发现您使用 ImageBox 来加载白色和黑色资源以及从光盘加载图像。这个根本不需要,直接用资源

Bitmap white = OomTestApp.Properties.Resources.white;
Bitmap black = OomTestApp.Properties.Resources.black;

然后要从光盘加载图像,只需使用 Bitmap.FromFile

我添加了一些行来正确释放您的资源 .Dispose 没有使用 using block 。

而且我还删除了 Clone() 调用,因为我认为它绝对不需要,因为您只是在计算原始图像的像素,而不是在那个图像中绘制任何东西观点。那么克隆图像的必要性是什么?

这是完整的代码(在您创建文件夹后开始)

if (errors == 0)
{
this.Height = 323;
goButton.Enabled = false;
stopButton.Enabled = true;

Bitmap white = OomTestApp.Properties.Resources.white;
Bitmap black = OomTestApp.Properties.Resources.black;
Bitmap bmWatermark = black;
Bitmap processImage = null;


progressBar1.Maximum = filesToProcess.Count;

foreach (string handleFile in filesToProcess)
{
    string fileName = System.IO.Path.GetFileName(handleFile);
    fileNameLabel.Text = "File: " + System.IO.Path.GetFileName(handleFile);
    try
    {
        // create backup if checked
        if (diOriginal != null)
        {
            System.IO.File.Move(handleFile, System.IO.Path.Combine(diOriginal.FullName, fileName));
            processImage = (Bitmap)Bitmap.FromFile(System.IO.Path.Combine(diOriginal.FullName, fileName));
        }
        else
        {
            processImage = (Bitmap)Bitmap.FromFile(handleFile);
        }

        double aspectRatio = (double)processImage.Width / (double)processImage.Height;

        using (Graphics gWatermark = Graphics.FromImage(processImage))
        {
            gWatermark.InterpolationMode = System.Drawing.Drawing2D.InterpolationMode.HighQualityBicubic;
            System.Drawing.SolidBrush drawBrush = new System.Drawing.SolidBrush(System.Drawing.Color.Black);

            // position watermark - watermark should be 10% of the image height
            int watermarkHeight = (int)(processImage.Height * 0.1);
            int watermarkPadding = (int)(watermarkHeight * 0.1); // not completely true, but asume watermark is square
            // calculate rectangle. if there is extra text, add extra padding below
            Rectangle watermarkArea = new Rectangle(watermarkPadding, processImage.Height - (watermarkPadding + (watermarkText.Text.Length == 0 ? 0 : watermarkPadding) + watermarkHeight), watermarkHeight, watermarkHeight);

            // determine color watermark
            bmWatermark = black;
            if (watermarkCombo.SelectedIndex == 0)
            {
                /*using (Bitmap watermarkClone = processImage.Clone(watermarkArea, processImage.PixelFormat))
                {*/
                var pixels = Pixels(processImage);
                if (pixels.Average((Func<Color, decimal>)Intensity) < 110) // human eye adoption; normal threshold should be 128
                {
                    bmWatermark = white;
                    drawBrush = new System.Drawing.SolidBrush(System.Drawing.Color.White);
                }
                //}
            }
            else if (watermarkCombo.SelectedIndex == 1)
            {
                bmWatermark = white;
                drawBrush = new System.Drawing.SolidBrush(System.Drawing.Color.White);
            }

            // draw the watermark
            gWatermark.DrawImage(bmWatermark, watermarkArea.X, watermarkArea.Y, watermarkArea.Width, watermarkArea.Height);

            // draw the text (if needed)
            if (watermarkText.Text.Length > 0)
            {
                System.Drawing.Font drawFont = new System.Drawing.Font("Tahoma", (float)watermarkPadding);
                gWatermark.DrawString(watermarkText.Text, drawFont, drawBrush, watermarkPadding, processImage.Height - (watermarkPadding * 2));
                drawFont.Dispose();
            }
            // disposing resources
            drawBrush.Dispose();

        }
        // save the watermarked file
        processImage.Save(System.IO.Path.Combine(diWatermarked.FullName, fileName), System.Drawing.Imaging.ImageFormat.Jpeg);


        // stop button pressed?
        Application.DoEvents();
        if (stopProcess) break;

        // update exection progress
        progressBar1.Value++;
        percentLabel.Text = ((int)((progressBar1.Value * 100) / filesToProcess.Count)).ToString() + "%";
        fileCountLabel.Text = "File " + progressBar1.Value.ToString() + "/" + filesToProcess.Count.ToString();
    }
    catch (Exception ex)
    {
        try
        {
            using (System.IO.StreamWriter sw = new System.IO.StreamWriter(System.IO.Path.Combine(folderText.Text, "errorlog.txt"), true))
            {
                sw.WriteLine("File: " + fileName);
                while (ex != null)
                {
                    sw.WriteLine("Message: " + ex.Message);
                    sw.WriteLine(ex.StackTrace);
                    sw.WriteLine(ex.Source);
                    ex = ex.InnerException;
                }
                sw.WriteLine();
            }
        }
        catch
        {
            // nothing to do - it already failed
        }
        errors++;
    }
    finally
    {
        if (processImage != null) processImage.Dispose();
    }
}

// dispose resources
white.Dispose();
black.Dispose();
bmWatermark.Dispose();



if (!stopProcess)
{
    // set status to complete
    fileCountLabel.Text = "File " + filesToProcess.Count.ToString() + "/" + filesToProcess.Count.ToString();
    percentLabel.Text = "100%";
    fileNameLabel.Text = "Completed...";
}
else
{
    fileNameLabel.Text = "Aborted...";
}

fileNameLabel.Text += errors.ToString() + " error(s) encountered";

// defaults to screen
progressBar1.Value = progressBar1.Maximum;
stopProcess = false;
goButton.Enabled = true;
stopButton.Enabled = false;

关于位图克隆上的 C# WinForms 内存不足异常,我们在Stack Overflow上找到一个类似的问题: https://stackoverflow.com/questions/19034524/

相关文章:

C# Foreach 循环创建一个新文件

C#在内存中以特定大小剪切图像而不保存文件

java - Android SurfaceView BitmapFactory 内存不足异常

c# - 不支持 MySql EF 6 存储过程导入函数 EDM 类型

c# - 在 LINQ 选择器中调用 ToArray 的性能影响

c# - MVP,类应该在哪里创建?

.net - 如何实现多行文本框的花式滚动条?

c# - 如何在配置中指定颜色

java - 如何使用 AffineTransform.quadrantRotate 旋转位图?

c# - Bitmap.Save 参数无效