c++ - 在函数调用时将值更改为随机数？

Question

#include <iostream>
#include "Shapes.h"

int main()
{
    //variables
    int height = 0;
    int width = 0;

    Rectangle rect = Rectangle();
    Triangle tran = Triangle();
    Square sqar = Square();

    std::cout << "What is the width of the shape? ";
    std::cin >> width;
    std::cout << "What is the height of the shape?";
    std::cin >> height;
    rect.set_lengths(width, height);
    std::cout << "If the shape is a triangle, the area is " << tran.area() << "." << std::endl;
    std::cout << "If the shape is a rectangle, the area is " << rect.area() << "." << std::endl;
    std::cout << "If the shape is a square, the area is " << sqar.areaByWidth() << " by the width value," << std::endl;
    std::cout << "and " << sqar.areaByHeight() << " by the height value." << std::endl;
    system("pause");
}

头文件:

//Our base class
class Shape 
{
protected:
    int width, height, shapes = 0;
public:
    void set_lengths(int width, int height)
    {
        width = width; height = height;
    }
};

//Rectangle is a shape
class Rectangle : public Shape 
{
public:
    Rectangle()
    {
        std::cout << "Created a rectangle!\n";
        shapes = shapes + 1;
    }
    ~Rectangle()
    {
        shapes = shapes - 1;
    }

    int area()
    {
        return width * height;
    }
};

//Triangle is a shape
class Triangle : public Shape 
{
public:
    Triangle()
    {
        shapes = shapes + 1;
        std::cout << "Created a triangle!\n";
    }
    ~Triangle()
    {
        shapes = shapes - 1;
    }
    int area()
    {
        return width * height / 2;
    }
};

//Square is a shape
class Square : public Shape 
{
public:
    Square()
    {
        shapes = shapes + 1;
        std::cout << "Created a square!";
    }
    ~Square()
    {
        shapes = shapes - 1;
    }
    int areaByWidth()
    {
        return width * width;
    }
    int areaByHeight()
    {
        return height * height;
    }
};

当我设置值时，它工作正常(在 visual studio 调试器中显示正确的值)，但是当我调用 area() 时它返回 -846388729 或类似的东西？为什么要重置值？几个小时以来，我一直在用头撞墙。对于像我这样的新手来说似乎是一个常见问题，但我不理解这里的其他解决方案:(

Answer 1

set_lengths 函数没有正确设置成员变量，只是将值设置回函数参数。

改变

void set_lengths(int width, int height)
{
    width = width; height = height;
}

到

void set_lengths(int width, int height)
{
    this->width = width; this->height = height;
}

或者改个成员变量的名字，养成好习惯:

int width_, height_, shapes_;
void set_lengths(int width, int height)
{
    width_ = width; 
    height_ = height;
}