javascript - 每个 then() 应该返回一个值或抛出 Promise/Always-return

Question

我正在创建一个推送通知应用程序，我使用node.js来部署firebase功能，但是在部署时显示错误。

warning Avoid nesting promises promise/no-nesting

warning Avoid nesting promises promise/no-nesting

error Each then() should return or throw promise/always-return

这是我的代码:

"use-strict";

const functions = require("firebase-functions");
const admin = require("firebase-admin");
admin.initializeApp(functions.config().firebase);

exports.sendNotification = functions.firestore
  .document("Users/{user_id}/Notification/{notification_id}")
  .onWrite(event => {
    const user_id = event.params.user_id;
    const notification_id = event.params.notification_id;

    return admin
      .firestore()
      .collection("Users")
      .doc(user_id)
      .collection("Notification")
      .doc(notification_id)
      .get()
      .then(queryResult => {
        const from_user_id = queryResult.data().from;
        const from_message = queryResult.data().message;
        const from_data = admin
          .firestore()
          .collection("Users")
          .doc(from_user_id)
          .get();
        const to_data = admin
          .firestore()
          .collection("Users")
          .doc(user_id)
          .get();

        return Promise.all([from_data, to_data]).then(result => {
          const from_name = result[0].data().name;
          const to_name = result[1].data().name;
          const token_id = result[1].data().token_id;
          const payload = {
            notification: {
              title: "Notification From :" + from_name,
              body: from_message,
              icon: "default"
            }
          };

          return admin
            .messaging()
            .sendToDevice(token_id, payload)
            .then(result => {
              console.log("Notification Sent.");
            });
        });
      });
  });

Answer 1

你没有提到错误在哪里。我认为错误将在行

console.log("通知已发送。");

如果你这样做

return console.log("通知已发送。");

错误应该消失，而警告仍然存在。

正如 Marcos 上面提到的，最好将 Promise 链接起来而不是嵌套。