javascript - winston.js 信息方法不传递元数据

Question

当我通过 winston 传递元数据时，快捷方式 winston.info 方法不会传递元数据。

var winston = require('winston');

winston.info("winston with metadata", {cluster: "bar"});
winston.log("info", "winston with metadata", {cluster: "baz"});

输出:

info: winston with metadata
info: winston with metadata cluster=baz

我希望这两个调用都能打印出元数据？

深入研究 winston 代码，它看起来像是为每个级别(“信息”、“调试”、“错误”)动态生成快捷函数，并尝试处理其他元数据参数:

//
// ### function setLevels (target, past, current)
// #### @target {Object} Object on which to set levels.
// #### @past {Object} Previous levels set on target.
// #### @current {Object} Current levels to set on target.
// Create functions on the target objects for each level
// in current.levels. If past is defined, remove functions
// for each of those levels.
//
exports.setLevels = function (target, past, current, isDefault) {
  if (past) {
    Object.keys(past).forEach(function (level) {
      delete target[level];
    });
  }

  target.levels = current || config.npm.levels;
  if (target.padLevels) {
    target.levelLength = exports.longestElement(Object.keys(target.levels));
  }

  //
  //  Define prototype methods for each log level
  //  e.g. target.log('info', msg) <=> target.info(msg)
  //
  Object.keys(target.levels).forEach(function (level) {
    target[level] = function (msg) {
      var args = Array.prototype.slice.call(arguments, 1),
          callback = args.pop(),
          ltype = typeof callback,
          meta = args.length ? args : null;

      if (ltype !== 'function') {
        if (meta && ltype !== 'undefined') {
          meta.push(callback);
        }

        callback = null;
      }

      if (meta) {
        meta = (meta.length <= 1 && meta.shift()) || meta;
        return callback
          ? target.log(level, msg, meta, callback)
          : target.log(level, msg, meta)
      }

      return callback
        ? target.log(level, msg, callback)
        : target.log(level, msg)
    };
  });

  return target;
};

Answer 1

我认为这很可能是由于 winston v0.7.1 中的回归。

鉴于此输入:

var winston = require("winston");

var logger = new winston.Logger({
    levels: {
        debug: 0,
        info: 1,
        warn: 2,
        error: 3
    },
  transports: [
      new winston.transports.Console({
          level: 'debug',
          colorize: true
      })
  ]
});

console.log('Winston Version: ' + winston.version);

console.log('\nProxy Methods\n');
logger.info("Hello world");
logger.warn("Hello world", { winston: {
    version: winston.version
}});

console.log('\nDirect Access Methods\n')
logger.log('info', "Hello world");
logger.log('warn', "Hello world", { version: winston.version });

你得到以下输出

Winston Version: 0.6.2

Proxy Methods

info: Hello world
warn: Hello world version=0.6.2

Direct Access Methods

info: Hello world
warn: Hello world version=0.6.2

对比:

Winston Version: 0.7.1

Proxy Methods

info: Hello world
warn: Hello world

Direct Access Methods

info: Hello world
warn: Hello world version=0.7.1

我已经更新了 https://github.com/flatiron/winston/pull/246在接受 PR 之前反射(reflect)回归。